Add Dockerfile #108
Merged
Add Dockerfile #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces containerization support by adding a Dockerfile, updating webhook scripts/configs, and creating a GitHub Action to publish the Docker image on releases.
- Add a multi-stage Dockerfile to build and run JPhyloRef in a container
- Update webhook start script, hooks configuration, and helper script for container paths and defaults
- Introduce a GitHub Actions workflow to publish the Docker image on release and refine the Maven CI workflow
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| webhook/start.sh | Add shebang, default PORT, and URL prefix |
| webhook/klados-backend.container | New Quadlet unit file for systemd-based container launch |
| webhook/hooks.json | Update execute-command paths, working directory, CORS headers, and base64 decoding |
| webhook/exec_jphyloref.sh | New helper script to uncompress input and invoke JPhyloRef |
| webhook/README.md | Document updated scripts and the new container definition |
| pom.xml | Set <finalName> so the built JAR matches expectations |
| Dockerfile | Add multi-stage build for Maven and runtime image |
| .github/workflows/maven.yaml | Upgrade setup-java action, enable Maven caching, and adjust triggers |
| .github/workflows/docker.yaml | Add release-triggered workflow to build and push Docker image |
Comments suppressed due to low confidence (1)
.github/workflows/maven.yaml:7
- [nitpick] Removing
pushevents means merges and direct commits to main won’t trigger CI. Consider re-addingpush(optionally limited to specific branches or tags) to ensure all changes are validated.
on: [pull_request, workflow_dispatch]
Also added documentation and did a bit of cleanup.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Replace `bash` invocation with an `env` invocation instead. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker images are now the best way to run packages on UF HiPerGator, so this PR adds a Dockerfile and a GitHub Action to generate a Docker package on releases.