This repository was archived by the owner on Jun 5, 2019. It is now read-only.
SECURITY-787 Speed up SimpleRole#equals #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did some profiling of our JBoss AS instance and `SimpleRole#equals` showed up as a hot method. A lot of time seems to be spent in `java.lang.Class.cast(Object)`. Switching to a normal Java cast should fix this since we're inside an `instanceof` and it always succeeds. * use normal cast in `SimpleRole#equals` instead of `java.lang.Class.cast` * add short circuit case for `this` Issue: SECURITY-787 https://issues.jboss.org/browse/SECURITY-787
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did some profiling of our JBoss AS instance and
SimpleRole#equalsshowed up as a hot method. A lot of time seems to be spent in
java.lang.Class.cast(Object). Switching to a normal Java cast shouldfix this since we're inside an
instanceofand it always succeeds.SimpleRole#equalsinstead ofjava.lang.Class.castthisIssue: SECURITY-787
https://issues.jboss.org/browse/SECURITY-787