Support working paths with whitespace#5
Open
thunderbird2678 wants to merge 2 commits intopiemadd:mainfrom
Open
Support working paths with whitespace#5thunderbird2678 wants to merge 2 commits intopiemadd:mainfrom
thunderbird2678 wants to merge 2 commits intopiemadd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the issue come up where because my github directory had a parent folder that contained whitespace, many of the commands in the patcher script would fail as they'd treat the whitespace as a separator for params.
Did this with a utility function to parse out the file in a safer manner and then changed the string addition to just passing in params and then joining them (cursor wanted to do this and i do think it looks cleaner)
Only tested on Windows as that's the only version of Subway Builder I have, would welcome people on Linux / Mac to give it a shot