Various changes to make demand data functional#6
Open
lastcommodore wants to merge 2 commits intopiemadd:mainfrom
Open
Various changes to make demand data functional#6lastcommodore wants to merge 2 commits intopiemadd:mainfrom
lastcommodore wants to merge 2 commits intopiemadd:mainfrom
Conversation
- Excessive pop sizes above 400 and below 50 are either split or culled - Airport terminal demand now works (Most jank patch of this bunch as workarounds had to be made with airports not having a numerical id, be warned) - Amenity is no longer queried for place (?) - Suburbs, hamlets, villages, and terminals now added as pop locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the demand data will inevitably have to be rewritten, as the current system creates way too many connections and is relatively inflexible, but in the meantime this makes the demand system actually playable as the previous version had pops so large it could not fit in subways and pops so small the connections would be 10x vanilla games and lag to hell and back