Skip to content

fix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzaloalonsod wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6958d26
implements ClientInterface
gonzaloalonsod Jun 11, 2018
23bf42e
new $this->clientClass($conn);
gonzaloalonsod Jun 11, 2018
7983001
function getClients
gonzaloalonsod Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Client/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
/**
* @author Pierre Rolland <roll.pierre@gmail.com>
*/
class Client
class Client implements ClientInterface
{
/** @var ConnectionInterface */
protected $connection;
Expand Down
5 changes: 5 additions & 0 deletions Client/ClientStack.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ public function removeClient(ConnectionInterface $connection)
unset($this->clients[$this->getClientIndex($connection)]);
}

public function getClients(): array
{
return $this->clients;
}

private function getClientIndex(ConnectionInterface $connection): int
{
foreach ($this->clients as $i => $c) {
Expand Down
2 changes: 1 addition & 1 deletion Websocket.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function __construct(HandlerRegistry $handlerRegistry, string $clientClas

public function onOpen(ConnectionInterface $conn)
{
$this->clientStack->addClient(new ${$this->clientClass}($conn));
$this->clientStack->addClient(new $this->clientClass($conn));
}

public function onMessage(ConnectionInterface $from, $msg)
Expand Down