Skip to content

Conversation

@jbellenger
Copy link

Implement api pagination. The semantics are:

  • if any single page request fails, reject the entire request
  • callbacks passed to Client.request will be called once the merged result
  • requests for each page are logged

Because this is potentially a breaking change, bump the version to 0.1.0.
Also change host.com to test.com, per rfc2606: reserved top level DNS names

Fixes #1

@jbellenger
Copy link
Author

Ping.

@pifantastic
Copy link
Owner

EEK! Sorry, missed this completely, will look ASAP.

@jbellenger
Copy link
Author

No problem! I appreciate it.

@pifantastic
Copy link
Owner

Thanks for the PR!

Looks like I've also had pagination code lying around uncommitted for awhile. Just pushed that up if you're interested in taking a look: https://github.com/pifantastic/node-sentry-api/tree/pagination

I like your change, but I'm worried about automatically loading all pages, as it could be potentially large. For example, I have projects that receive tens of thousands of events an hour. My solution was to return a cursor for each request, so the caller could decide to make subsequent requests if they need to.

I think a combination of our approaches might be desirable?

@pifantastic
Copy link
Owner

Or maybe we just add a limit param and adjust your code to stop at limit results?

@djmitche
Copy link

Note that this repo is being forked to https://github.com/taskcluster/node-sentry-api. If you'd like to see this functionality merged, we'll be happy to consider a PR, but my guess is that this has bitrotted in the last four years..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Releases.files only returns up to 100 files

3 participants