Skip to content

fix: fix admin dropdown menu overflow at viewport bottom #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piffio merged 1 commit into from
Apr 24, 2026
+30 −2
Merged

fix: fix admin dropdown menu overflow at viewport bottom #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion frontend/src/routes/admin/links/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,22 @@
dropdownPosition = null;
} else {
activeDropdown = linkId;

// Estimate dropdown height (~5 items at ~33px each + padding ≈ 200px)
const estimatedMenuHeight = 200;
const spaceBelow = window.innerHeight - rect.bottom;

let top: number;
if (spaceBelow < estimatedMenuHeight && rect.top > estimatedMenuHeight) {
// Not enough space below, open upward
top = rect.top - estimatedMenuHeight - 4;
} else {
// Default: open below
top = rect.bottom + 4;
}

dropdownPosition = {
top: rect.bottom + 4,
top,
right: window.innerWidth - rect.right
};
}
Expand Down
16 changes: 15 additions & 1 deletion frontend/src/routes/admin/users/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,22 @@
dropdownPosition = null;
} else {
activeDropdown = userId;

// Estimate dropdown height (~5 items at ~33px each + padding ≈ 200px)
const estimatedMenuHeight = 200;
const spaceBelow = window.innerHeight - rect.bottom;

let top: number;
if (spaceBelow < estimatedMenuHeight && rect.top > estimatedMenuHeight) {
// Not enough space below, open upward
top = rect.top - estimatedMenuHeight - 4;
} else {
// Default: open below
top = rect.bottom + 4;
}

dropdownPosition = {
top: rect.bottom + 4,
top,
right: window.innerWidth - rect.right
};
}
Expand Down
Loading