Fix Docker deployment and configuration documentation inconsistencies#5
Fix Docker deployment and configuration documentation inconsistencies#5
Conversation
|
@piiq 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: piiq <11668535+piiq@users.noreply.github.com>
|
@copilot check that the logic and the documentation around error doesn't seem related to the host url. |
…ble inconsistencies Co-authored-by: piiq <11668535+piiq@users.noreply.github.com>
You're absolutely correct! The Issues found:
Fixed in commit 2526bd8:
The validation logic in |
The Docker deployment documentation and configuration files contained multiple inconsistencies that caused validation errors during container startup. This fix addresses both the original
HOST_URLvsAGENT_HOST_URLmismatch and additional configuration documentation issues.Issues Fixed:
HOST_URLbut application expectsAGENT_HOST_URLHOST_URLvariable nameDATA_FOLDER_PATHwas listed as "optional" when it's actually required when S3 is disabledBefore (broken configuration):
This caused validation errors:
After (working configuration):
Changes Made:
AGENT_HOST_URLinstead ofHOST_URL.env.exampleto use correct environment variable namesDATA_FOLDER_PATHis required when S3 is disabled (default behavior)The corrected documentation now matches the actual validation logic in
allocator_bot/models.pyand is consistent across all configuration files including Kubernetes manifests.Fixes #4.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.