Skip to content

add screen size macros#85

Open
zenodante wants to merge 1 commit intopimoroni:mainfrom
zenodante:mod
Open

add screen size macros#85
zenodante wants to merge 1 commit intopimoroni:mainfrom
zenodante:mod

Conversation

@zenodante
Copy link
Copy Markdown

Hi, I added SCREEN_WIDTH and SCREEN_HEIGHT defines to the picosystem.hpp. Then the code in picosystem.cpp could be simplified a little.

@Gadgetoid
Copy link
Copy Markdown
Member

sigh the Python linting fails are my bad, I didn't pin the flake8 version so it's picking up things that previously didn't register as an error.

With that said, uh, do you mind... fixing them... and popping on another commit so I can merge this? 😆

test.py's update should be:

def update(tick):
    global view

    if pressed(RIGHT):
        view += 1

    if pressed(LEFT):
        view -= 1

    view %= view_count

@ahnlak ahnlak mentioned this pull request Sep 12, 2022
@Gadgetoid
Copy link
Copy Markdown
Member

The above fixes have been added in #87 - you should just be able to rebase this PR and it'll pass CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants