Fix segmentation fault by adding ctypes function signatures#60
Open
Odinroast wants to merge 1 commit intopimoroni:masterfrom
Open
Fix segmentation fault by adding ctypes function signatures#60Odinroast wants to merge 1 commit intopimoroni:masterfrom
Odinroast wants to merge 1 commit intopimoroni:masterfrom
Conversation
The library was crashing with 'Segmentation fault (core dumped)' when calling start_ranging() and other methods on Python 3.7+ and 64-bit systems. Root cause: ctypes was treating the pointer returned by initialise() as a 32-bit int instead of a 64-bit pointer, causing pointer truncation on 64-bit architectures. Solution: Added explicit argtypes and restype declarations for all C function calls to preserve full pointer addresses. Fixes segmentation faults reported in multiple issues on: - Python 3.7+ - Raspberry Pi 4B, 5 - Jetson Nano, Orin - Ubuntu 64-bit systems Tested on: Jetson Orin with Python 3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library was crashing with 'Segmentation fault (core dumped)' when calling start_ranging() and other methods on Python 3.7+ and 64-bit systems.
Root cause: ctypes was treating the pointer returned by initialise() as a 32-bit int instead of a 64-bit pointer, causing pointer truncation on 64-bit architectures.
Solution: Added explicit argtypes and restype declarations for all C function calls to preserve full pointer addresses.
Fixes segmentation faults reported in multiple issues on:
Tested on: Jetson Orin with Python 3.10