My take on your back end challenge for your consideration#9
Open
gwengullett wants to merge 10 commits intopindropsecurity:masterfrom
Open
My take on your back end challenge for your consideration#9gwengullett wants to merge 10 commits intopindropsecurity:masterfrom
gwengullett wants to merge 10 commits intopindropsecurity:masterfrom
Conversation
Added documentation to primary working class "SummitNode". Nailing down basic interface.
First version of evaluation complete.
…ity of nested SummitNode objects. Upgraded evaluation for division, checking for zero division and chastising for it. Added more documentation.
Reformatted for pep8, nothing like good clean code!
…if all inputs are simple integers, integer division is used, otherwise, in mixed usage or all float-cases it will use floating point division.
Added Version Added package level import for SummitNode Added additional unittests for special division cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100% code coverage via unittests
pep8 checked / compliant
You can run all tests and pep8 automatically using tox, I have it configured to test against Python2.7 and Python3.4 and includes coverage reporting.
I have also added sphinx documentation throughout the code and a narrative style manual. I have built the documentation in advance and committed it under docs/build/html start with index.html to view all documentation.
Documentation is split between narrative (user manual) and developer reference (autodoc, class reference).
Please let me know if you have any questions, comments, or concerns or if you want to just throw something at me or shoot me with a Nerf weapon.