Skip to content

feat: custom-notes feature in webui #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MasterK0927 wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat: custom-notes feature in webui #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
106eac1
added new notes feature with ui in c++
MasterK0927 Sep 11, 2024
5ed4f70
ui is getting rendered, functions are not working as of now
MasterK0927 Sep 14, 2024
8d5cb2f
now the notes feature is full functional just need to add ui renderin…
MasterK0927 Sep 16, 2024
5792560
removed the utils changes
MasterK0927 Sep 16, 2024
759eeda
added the view for saved notes, although its not realtime as of now
MasterK0927 Sep 26, 2024
30e6bf3
added webui page for ping://custom-notes
MasterK0927 Sep 30, 2024
9a12273
added changes in ids.spec
MasterK0927 Oct 1, 2024
3a8a60d
some changes for better approach
MasterK0927 Oct 2, 2024
8cc4fb4
Now Working
MasterK0927 Oct 3, 2024
c933e8d
integrated mojom
MasterK0927 Oct 7, 2024
90c1c4a
mojo message pipe is now working fine, there are still few errors in …
MasterK0927 Oct 10, 2024
1ac8fad
custom_notes all features impl successfully, a date fetch bug just re…
MasterK0927 Oct 11, 2024
e92518e
working but response not coming, debugging it
MasterK0927 Oct 18, 2024
73907f0
new changes, response is getting received from the server but not get…
MasterK0927 Oct 21, 2024
173ee6f
callbacks implemented successfully, asynchronous architecture is full…
MasterK0927 Nov 16, 2024
f17c3b0
improved code quality
MasterK0927 Nov 16, 2024
1999dc0
api call from internal page using javascript working
MasterK0927 Nov 28, 2024
b471feb
override function for iswebuiallowedtomakenetworkrequests
MasterK0927 Nov 30, 2024
2e03044
Merge branch 'feat/custom-notes' into sign-final-keshav
MasterK0927 Dec 29, 2024
c27c74a
fix: merge conflict in resources mapping
MasterK0927 Dec 29, 2024
8efa9ca
sync: migrating webui_url_constants
MasterK0927 Dec 30, 2024
415e9d9
fix: 130 sync is now fully merged, with all the features working
MasterK0927 Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions browser/brave_content_browser_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ using extensions::ChromeContentBrowserClientExtensionsPart;
#if !BUILDFLAG(IS_ANDROID)
#include "brave/browser/new_tab/new_tab_shows_navigation_throttle.h"
#include "brave/browser/ui/geolocation/brave_geolocation_permission_tab_helper.h"
#include "brave/browser/ui/webui/brave_custom_notes/brave_custom_notes_ui.h"
#include "brave/browser/ui/webui/brave_news_internals/brave_news_internals_ui.h"
#include "brave/browser/ui/webui/brave_rewards/rewards_page_top_ui.h"
#include "brave/browser/ui/webui/brave_rewards/rewards_panel_ui.h"
Expand All @@ -233,6 +234,7 @@ using extensions::ChromeContentBrowserClientExtensionsPart;
#include "brave/browser/ui/webui/brave_wallet/wallet_panel_ui.h"
#include "brave/browser/ui/webui/new_tab_page/brave_new_tab_ui.h"
#include "brave/browser/ui/webui/private_new_tab_page/brave_private_new_tab_ui.h"
#include "brave/components/brave_custom_notes/common/brave_custom_notes.mojom.h"
#include "brave/components/brave_new_tab_ui/brave_new_tab_page.mojom.h"
#include "brave/components/brave_news/common/brave_news.mojom.h"
#include "brave/components/brave_news/common/features.h"
Expand Down Expand Up @@ -805,6 +807,8 @@ void BraveContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(
brave_wallet::mojom::PanelHandlerFactory, WalletPanelUI>(map);
content::RegisterWebUIControllerInterfaceBinder<
brave_private_new_tab::mojom::PageHandler, BravePrivateNewTabUI>(map);
content::RegisterWebUIControllerInterfaceBinder<
brave_custom_notes::mojom::NotesPageHandler, BraveCustomNotesUI>(map);
content::RegisterWebUIControllerInterfaceBinder<
brave_shields::mojom::PanelHandlerFactory, ShieldsPanelUI>(map);
if (base::FeatureList::IsEnabled(
Expand Down
1 change: 1 addition & 0 deletions browser/brave_profile_prefs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ void RegisterProfilePrefsForMigration(

// Added 10/2022
registry->RegisterIntegerPref(kDefaultBrowserLaunchingCount, 0);
registry->RegisterListPref("custom_notes");
#endif
brave_wallet::RegisterProfilePrefsForMigration(registry);

Expand Down
2 changes: 2 additions & 0 deletions browser/sources.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ brave_chrome_browser_deps = [
"//brave/components/brave_perf_predictor/browser",
"//brave/components/brave_private_new_tab_ui/common",
"//brave/components/brave_private_new_tab_ui/common:mojom",
"//brave/components/brave_custom_notes/common",
"//brave/components/brave_custom_notes/common:mojom",
"//brave/components/brave_referrals/browser",
"//brave/components/brave_rewards/common",
"//brave/components/brave_rewards/common:features",
Expand Down
9 changes: 9 additions & 0 deletions browser/ui/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,12 @@ source_set("ui") {
"webui/private_new_tab_page/brave_private_new_tab_page_handler.h",
"webui/private_new_tab_page/brave_private_new_tab_ui.cc",
"webui/private_new_tab_page/brave_private_new_tab_ui.h",
"webui/brave_custom_notes/brave_custom_notes_handler.cc",
"webui/brave_custom_notes/brave_custom_notes_handler.h",
"webui/brave_custom_notes/brave_custom_notes_ui.cc",
"webui/brave_custom_notes/brave_custom_notes_ui.h",
"webui/brave_custom_notes/brave_custom_notes_api_handler.cc",
"webui/brave_custom_notes/brave_custom_notes_api_handler.h",
"webui/settings/brave_adblock_handler.cc",
"webui/settings/brave_adblock_handler.h",
"webui/settings/brave_appearance_handler.cc",
Expand Down Expand Up @@ -1053,6 +1059,9 @@ source_set("ui") {
"//brave/components/brave_private_new_tab_ui/common",
"//brave/components/brave_private_new_tab_ui/common:mojom",
"//brave/components/brave_private_new_tab_ui/resources/page:generated_resources",
"//brave/components/brave_custom_notes/common",
"//brave/components/brave_custom_notes/common:mojom",
"//brave/components/brave_custom_notes/resources/page:generated_resources",
"//brave/components/brave_rewards/browser",
"//brave/components/brave_rewards/resources/rewards_panel:brave_rewards_panel_generated",
"//brave/components/brave_rewards/resources/tip_panel:tip_panel_generated",
Expand Down
Loading