Skip to content

variables.json: update the value of the starter variable #20737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2025
Merged

variables.json: update the value of the starter variable #20737

merged 3 commits into from
Aug 12, 2025

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Aug 11, 2025 •
edited
Loading

What is changed, added or deleted? (Required)

This PR updates the value of the starter variable from "TiDB Cloud Serverless" to "TiDB Cloud Starter".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Aug 11, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2025
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Aug 11, 2025
@lilin90 lilin90 added the rename-serverless This PR is caused by renaming TiDB Cloud Serverless. label Aug 11, 2025
lilin90
lilin90 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-11 07:58:07.571535728 +0000 UTC m=+254286.606118946: ☑️ agreed by lilin90.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 11, 2025
@qiancai
Copy link
Collaborator Author

qiancai commented Aug 12, 2025

/approve

@qiancai qiancai added the lgtm label Aug 12, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 12, 2025
@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@qiancai qiancai merged commit 5b91480 into pingcap:master Aug 12, 2025
7 checks passed
@qiancai qiancai deleted the update-starter-variable-value-21547 branch August 12, 2025 11:06
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 12, 2025
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#20737
ce40fbe 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20760.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 12, 2025
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 12, 2025
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#20737
427ad8e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20761.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 12, 2025
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 12, 2025
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#20737
4ba536f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20762.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 12, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 12, 2025
@ti-chi-bot
variables.json: update the value of the starter variable (#20737) (#2…
3da65b4 
…0762)
ti-chi-bot bot pushed a commit that referenced this pull request Aug 12, 2025
@ti-chi-bot
variables.json: update the value of the starter variable (#20737) (#2…
2eaa62a 
…0761)
qiancai added a commit that referenced this pull request Aug 12, 2025
@ti-chi-bot @qiancai
variables.json: update the value of the starter variable (#20737) (#2…
d241abf 
…0760)

Co-authored-by: Grace Cai <qqzczy@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. rename-serverless This PR is caused by renaming TiDB Cloud Serverless. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiancai @ti-chi-bot @lilin90