support wait tiflash replica ready #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
force-pushed
the
add_wait_tiflash_replica_ready
branch
from
6b1f482 to
fe11a09
Compare
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Defined2014
reviewed
Dec 10, 2025
src/type.go
Outdated
| "single_query": Q_SINGLE_QUERY, | ||
| "begin_concurrent": Q_BEGIN_CONCURRENT, | ||
| "end_concurrent": Q_END_CONCURRENT, | ||
| "wait_tiflash_replica_ready": Q_WAIT_TIFLASH_REPLICA_READY, |
Defined2014
reviewed
Dec 10, 2025
| if q.tp == Q_UNKNOWN || q.tp == Q_COMMENT_WITH_COMMAND { | ||
| switch q.tp { | ||
| case Q_COMMENT_WITH_COMMAND: | ||
| if err := q.getQueryType(s); err != nil { |
Member
Author
There was a problem hiding this comment.
If I use realS, it will be unavailable for this functions.
Member
Author
There was a problem hiding this comment.
Q_COMMENT_WITH_COMMAND will remove the -- prefix and save command name into s.
Defined2014
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test in https://github.com/PingCAP-QE/planreplayertest/pull/23
Because adding TiFlash to TiDB is an asynchronous process, to ensure the stability of the test, we need to wait for all replicas to be ready.