Skip to content

Conversation

@Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Nov 12, 2025

What problem does this PR solve?

Issue Number: ref #62664

Problem Summary:
To be compatible with partial index for repairing ingest index after log restore

What changed and how does it work?

recognize the IndexInfo.ConditionExprString

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Nov 12, 2025
@tiprow
Copy link

tiprow bot commented Nov 12, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.2628%. Comparing base (8c27816) to head (46d88aa).
⚠️ Report is 28 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64434        +/-   ##
================================================
+ Coverage   72.6827%   75.2628%   +2.5801%     
================================================
  Files          1865       1867         +2     
  Lines        506065     513443      +7378     
================================================
+ Hits         367822     386432     +18610     
+ Misses       115852     103964     -11888     
- Partials      22391      23047       +656     
Flag Coverage Δ
integration 45.8371% <100.0000%> (?)
unit 73.1189% <0.0000%> (+0.8638%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.6156% <100.0000%> (+17.4051%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-12 06:20:08.284925317 +0000 UTC m=+855857.727955196: ☑️ agreed by YangKeao.
  • 2025-11-18 04:07:37.388822839 +0000 UTC m=+1366306.831852717: ☑️ agreed by 3pointer.

@BornChanger
Copy link
Contributor

/retest

@tiprow
Copy link

tiprow bot commented Nov 18, 2025

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 4c01e06 into pingcap:master Nov 18, 2025
42 of 46 checks passed
@YangKeao
Copy link
Member

/cherry-pick release-8.5-20260116-v8.5.5

@ti-chi-bot
Copy link
Member

@YangKeao: new pull request created to branch release-8.5-20260116-v8.5.5: #65917.

Details

In response to this:

/cherry-pick release-8.5-20260116-v8.5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants