*: cherry-pick 1m user feature to 8.5 hotfix branch | tidb-test=pr/2673 #65883

tiancaiamao · 2026-01-28T11:32:30Z

What problem does this PR solve?

Issue Number: ref #55563

Problem Summary:

What changed and how does it work?

Cherry-pick the following PR to release 8.5 hotfix branch

commit 949fc53e97b826342d7acdc2295ce3c4f0b57490
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Fri Feb 28 22:45:19 2025 +0800

    metrics: add metrics for active users count (#59533)

    ref pingcap/tidb#55563


commit b61e0e16ef80f5760e427cec4d945518d159ad48
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Thu Feb 27 14:54:06 2025 +0800

    privilege, domain: reduce the memory jitter of privilege reload activity for 2M users (#59487)

    ref pingcap/tidb#55563, close pingcap/tidb#59403


commit 397b0f228a93d4b7323baa6f02a4c895449017f4
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Wed Feb 12 11:35:32 2025 +0800

    *: add sql variable @@tidb_accelerate_user_creation_update (#58512)

    ref pingcap/tidb#55563

commit 2efcabb11d0f11ad43c80f1a13b8092907fa8116
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Tue Feb 11 12:41:18 2025 +0800

    privilege/privileges:  refactor the data struct for user privilege data (#58945)

    close pingcap/tidb#55563

commit 8e1a47dddb1ee0f2469493688fe66d691ea13104
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Thu Dec 26 13:44:06 2024 +0800

    session: add index on 'user' field for mysql tables (#57470)

    ref pingcap/tidb#55563

commit ec288d95a31a8cc946b23ba2c0265a1bb50786dc
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Fri Nov 29 21:16:54 2024 +0800

    *: avoid notify privilege update for all users (#57042)

    ref pingcap/tidb#55563

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ref pingcap#55563

pingcap#58945) close pingcap#55563

…8512) ref pingcap#55563

…ity for 2M users (pingcap#59487) ref pingcap#55563, close pingcap#59403

ref pingcap#55563

tiprow · 2026-01-28T11:32:47Z

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2026-01-28T11:54:32Z

Codecov Report

❌ Patch coverage is 80.57143% with 170 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5-20260116-v8.5.5@ee48f0b). Learn more about missing BASE report.

Additional details and impacted files

@@                       Coverage Diff                        @@
##             release-8.5-20260116-v8.5.5     #65883   +/-   ##
================================================================
  Coverage                               ?   73.2404%           
================================================================
  Files                                  ?       1683           
  Lines                                  ?     469806           
  Branches                               ?          0           
================================================================
  Hits                                   ?     344088           
  Misses                                 ?     102829           
  Partials                               ?      22889

Flag	Coverage Δ
integration	`50.9151% <72.1142%> (?)`
unit	`64.9373% <74.6285%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9278% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`63.8744% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tiancaiamao · 2026-01-29T03:01:24Z

/test mysql-test

tiprow · 2026-01-29T03:01:48Z

@tiancaiamao: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2026-01-29T08:33:22Z

/retest

tiprow · 2026-01-29T08:34:02Z

@tiancaiamao: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2026-01-29T09:29:25Z

/retest

tiprow · 2026-01-29T09:29:49Z

@tiancaiamao: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2026-01-29T09:40:48Z

/retest

tiprow · 2026-01-29T09:41:12Z

@tiancaiamao: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2026-01-29T11:43:15Z

/test unit-test

tiprow · 2026-01-29T11:43:39Z

@tiancaiamao: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2026-01-29T12:12:55Z

/retest

tiprow · 2026-01-29T12:13:18Z

@tiancaiamao: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2026-01-29T12:45:06Z

/retest

tiprow · 2026-01-29T12:45:33Z

@tiancaiamao: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-01-29T14:25:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bb7133, wjhuang2016
Once this PR has been reviewed and has the lgtm label, please assign yudongusa, yujuncen for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bb7133,wjhuang2016]
br/OWNERS
~~pkg/ddl/OWNERS~~ [wjhuang2016]
~~pkg/domain/OWNERS~~ [wjhuang2016]
pkg/session/OWNERS
pkg/sessionctx/variable/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-01-29T14:25:13Z

[LGTM Timeline notifier]

Timeline:

2026-01-29 14:15:37.574475518 +0000 UTC m=+1280965.188432374: ☑️ agreed by wjhuang2016.
2026-01-29 14:25:11.562719099 +0000 UTC m=+1281539.176675945: ☑️ agreed by bb7133.

tiancaiamao added 6 commits January 28, 2026 15:55

*: avoid notify privilege update for all users (pingcap#57042)

d77f80e

ref pingcap#55563

session: add index on 'user' field for mysql tables (pingcap#57470)

75d0c65

ref pingcap#55563

privilege/privileges: refactor the data struct for user privilege data (

91b1a0c

pingcap#58945) close pingcap#55563

*: add sql variable @@tidb_accelerate_user_creation_update (pingcap#5…

a8028eb

…8512) ref pingcap#55563

privilege, domain: reduce the memory jitter of privilege reload activ…

0339f91

…ity for 2M users (pingcap#59487) ref pingcap#55563, close pingcap#59403

metrics: add metrics for active users count (pingcap#59533)

5ad1d08

ref pingcap#55563

ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 28, 2026

make fmt & make bazel_prepare

a80aa74

tiancaiamao changed the title ~~cherry-pick 1m user feature to 8.5 hotfix branch~~ *: cherry-pick 1m user feature to 8.5 hotfix branch Jan 28, 2026

ti-chi-bot bot removed the do-not-merge/invalid-title label Jan 28, 2026

tiancaiamao added 2 commits January 28, 2026 21:55

make lint happy

93fcf15

make lint happy

7878194

tiancaiamao changed the title *: cherry-pick 1m user feature to 8.5 hotfix branch *: cherry-pick 1m user feature to 8.5 hotfix branch | tidb-test=pr/2673 Jan 29, 2026

tiancaiamao added 6 commits January 29, 2026 12:11

fix test case TestEnsureActiveUserCoverage

f42e57d

fix test

baf1a3a

recover the 'active users' grafana

761465f

fix issues found by codex GPT 5.2

cdc5a8a

fix CI TestPluginUserModification

b33fd99

fix 'set password for user' call ensureActiveUser

19b0be9

fix CI

6dfdf93

fix CI

4705895

wjhuang2016 approved these changes Jan 29, 2026

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 29, 2026

bb7133 approved these changes Jan 29, 2026

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 29, 2026

*: cherry-pick 1m user feature to 8.5 hotfix branch | tidb-test=pr/2673 #65883

Are you sure you want to change the base?

*: cherry-pick 1m user feature to 8.5 hotfix branch | tidb-test=pr/2673 #65883

Conversation

tiancaiamao commented Jan 28, 2026

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tiancaiamao commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

tiancaiamao commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

tiancaiamao commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

tiancaiamao commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

tiancaiamao commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

tiancaiamao commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

tiancaiamao commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

ti-chi-bot bot commented Jan 29, 2026

Uh oh!

ti-chi-bot bot commented Jan 29, 2026

[LGTM Timeline notifier]

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 28, 2026 •

edited

Loading