Skip to content

[agent] fix(web): include Claude models in git text generation model picker#1222

Open
alexng353 wants to merge 1 commit intopingdotgg:mainfrom
alexng353:fix/git-text-gen-claude-models
Open

[agent] fix(web): include Claude models in git text generation model picker#1222
alexng353 wants to merge 1 commit intopingdotgg:mainfrom
alexng353:fix/git-text-gen-claude-models

Conversation

@alexng353
Copy link

@alexng353 alexng353 commented Mar 20, 2026

Summary

  • The "Text generation model" dropdown in Settings → Git only listed Codex models
  • With Claude now a first-class provider (feat: add Claude Code adapter #179), users should be able to select Claude models for auto-generated commit messages, PR titles, and branch names
  • Merges both Codex and Claude model lists (with dedup) into the picker

Fixes #1221

See also #1219 for default model/provider settings (separate concern, but related).

Changes

One file changed (apps/web/src/routes/_chat.settings.tsx):

  • gitTextGenerationModelOptions now combines models from both providers instead of hardcoding "codex"

This PR was generated by AI (Claude Code). All code changes were authored by Claude Opus 4.6.

Test plan

  • Open Settings → Git → Text generation model dropdown
  • Verify Claude models (Opus 4.6, Sonnet 4.6, Haiku 4.5) appear alongside Codex models
  • Select a Claude model, verify it persists
  • Verify "Restore default" still works

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

…picker

The text generation model dropdown in Settings only listed Codex models.
With Claude now a first-class provider, users should be able to select
Claude models for auto-generated commit messages, PR titles, and branch
names.

This change merges both Codex and Claude model lists (with dedup) into
the git text generation model picker.

> This code was generated by AI (Claude Code).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0c0baf48-902a-4a99-85d8-820241612855

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 20, 2026
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no text generation backend service for Claude so this will fail

@MaximIJ
Copy link

MaximIJ commented Mar 21, 2026

I took a pass at the backend piece raised in review and got this working end to end locally.

What was missing:

  • the Git settings UI exposed Claude models, but the server only had a Codex-backed git text generation path
  • the web mutation was sending model instead of textGenerationModel, so the selected Git model never reached the backend
  • the settings picker also rendered duplicate Claude entries in some cases

What I changed locally:

  • added a Claude-backed git text generation service for commit messages and PR content
  • routed git text generation by selected model
  • fixed the web payload so textGenerationModel reaches the server
  • deduped the Git model picker options
  • added tests for routing and settings behavior

Local checks passed:

  • bun fmt
  • bun lint
  • bun typecheck

If helpful, I can open a replacement PR from my fork or provide a cherry-pickable commit/branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Allow Claude to generate commit messages

3 participants