Flatten Git service layer and switch server paths to base dir#1255
Open
juliusmarminge wants to merge 1 commit intomainfrom
Open
Flatten Git service layer and switch server paths to base dir#1255juliusmarminge wants to merge 1 commit intomainfrom
juliusmarminge wants to merge 1 commit intomainfrom
Conversation
- remove the GitService layer and wire callers to GitCore directly - update checkpointing and orchestration wiring to provide GitCore - adjust git layer tests and harnesses for the new structure
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitCore, removing the separateGitServicelayer and updating downstream consumers and tests.T3CODE_HOME/--base-dir.Testing
bun fmt,bun lint,bun typecheck, andbun run test.Note
Flatten Git service layer by merging GitService execution into GitCore
GitServiceas a dependency layer;GitCorenow owns git process execution directly via an internalexecute(input)method built withChildProcessSpawnerExecuteGitInputCheckpointStoreLiveno longer auto-provides a Git implementation — callers must explicitly wire aGitCorelayer when composing the environmentGitCoreLivedirectlyCheckpointStoreLiveis a breaking change for any caller that previously relied on it bundlingGitServiceLiveinternallyMacroscope summarized d100711.