refactor: standardize error logging across codebase #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Use %w for error wrapping instead of %s with err.Error() - Lowercase error message prefixes (Error→error, Failed→failed, etc.) - Remove redundant .Error() calls in log statements - Standardize punctuation (; instead of . in compound messages) - Normalize brand name capitalization (Knox→knox in errors) - Update test expectations to match new error messages - Make TestNewFileClient more resilient with prefix matching This is a mechanical refactoring with no functional changes. All tests pass after this change.
xia0pin9
force-pushed
the
refactor/log-standardization
branch
from
9ac99df to
d3d5c37
Compare
csstaub
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This is a mechanical refactoring with no functional changes. All tests pass after this change.