Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 146 200 +54
=========================================
+ Hits 146 200 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengelbart
force-pushed
the
feat/trendline-estimator
branch
from
4ecc97a to
0b28bb2
Compare
JoTurk
approved these changes
Mar 7, 2026
Comment on lines
+61
to
+63
| smoothedDelayMs := e.smoothingCoeff*float64(e.smoothedDelay.Milliseconds()) + | ||
| (1-e.smoothingCoeff)*float64(e.accumulatedDelay.Milliseconds()) | ||
| e.smoothedDelay = time.Duration(smoothedDelayMs * float64(time.Millisecond)) |
Member
There was a problem hiding this comment.
I think we can make this float instead of truncating to ms.
|
|
||
| trend, ok := fitSlope(e.history) | ||
| if !ok { | ||
| trend = e.previousTrend |
Member
There was a problem hiding this comment.
we don't seem to set previousTrend is this intended for future work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trendline estimator will be used to estimate the slope of inter-arrival times. It is a simpler alternative to the Kalman filter.