Check if only the NOMINATION attribute is set for binding request#884
Open
martinxsliu wants to merge 2 commits intopion:masterfrom
Open
Check if only the NOMINATION attribute is set for binding request#884martinxsliu wants to merge 2 commits intopion:masterfrom
martinxsliu wants to merge 2 commits intopion:masterfrom
Conversation
Member
|
(i closed and opened this PR, because Github CI was stuck). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 44 44
Lines 5540 5540
==========================================
- Hits 4905 4904 -1
- Misses 440 441 +1
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
approved these changes
Feb 9, 2026
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
Can we add a test for this?
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #881
libwebrtc's implementation of ICE renomination only sets the NOMINATION attribute and not the USE_CANDIDATE attribute when renomination is enabled and libwebrtc is controlling: https://webrtc.googlesource.com/src/+/refs/heads/main/p2p/base/connection.cc#1157.
In order to make Pion compatible with libwebrtc, this PR updates the handle binding request check to look for either attribute.