Wrap short-packet errors with packet context#211
Open
debugmenot wants to merge 2 commits intopion:masterfrom
Open
Wrap short-packet errors with packet context#211debugmenot wants to merge 2 commits intopion:masterfrom
debugmenot wants to merge 2 commits intopion:masterfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (59.79%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 77.07% 77.03% -0.04%
==========================================
Files 22 23 +1
Lines 2569 2086 -483
==========================================
- Hits 1980 1607 -373
+ Misses 493 381 -112
- Partials 96 98 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wrap all code paths that return errPacketTooShort so the error message now includes the packet or header type while keeping errors.Is compatibility
add helper utilities (packetTooShortError, packetNameFromHeader) to centralize naming logic. packetNameFromHeader can be used later to fine-tune other errors with their origin
update existing unmarshallers and size checks to use the helper, improving observability across RTCP packet types
extend the test suite to cover the new behavior, including unit tests for the helper and a regression test on the existing invalid-header scenario
Reference issue
#Implements improvement #208