Resolve the empty address to INADDR_ANY in VNet#377
Open
rg0now wants to merge 1 commit intopion:masterfrom
Open
Resolve the empty address to INADDR_ANY in VNet#377rg0now wants to merge 1 commit intopion:masterfrom
rg0now wants to merge 1 commit intopion:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 84.67% 84.68%
=======================================
Files 38 38
Lines 3074 3076 +2
=======================================
+ Hits 2603 2605 +2
Misses 339 339
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
approved these changes
Feb 8, 2026
| var err error | ||
|
|
||
| if address == "" { | ||
| address = "0.0.0.0" |
Member
There was a problem hiding this comment.
I think it will be cleaner if we use net.IPv4zero also we should prob handle ipv6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So far calling
VNet.ListenPacket("udp4", ":1234")with the shorthand empty address has failed by "host not found" inVNet.ResolveIPAddr.This PR makes sure the empty address resolves to
INADDR_ANY.