Only send requested-family for IPV6 allocations#549
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 81.63% 81.59% -0.04%
==========================================
Files 46 46
Lines 3191 3195 +4
==========================================
+ Hits 2605 2607 +2
- Misses 384 385 +1
- Partials 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philipch07
approved these changes
Jan 30, 2026
Member
Author
|
@rg0now based on @philipch07 approval and that you voted for this change in the issue, I'm going to merge and tag this to hopefully fix #547 . it shouldn't break anything. |
Contributor
|
Thanks for this @JoTurk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this helper enforces two constraints on sending REQUESTED-ADDRESS-FAMILY:
should fix #547