Fix: FINGERPRINT as last attribute#556
Merged
adrianosela merged 1 commit intopion:masterfrom Feb 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 81.59% 81.65% +0.06%
==========================================
Files 46 46
Lines 3195 3195
==========================================
+ Hits 2607 2609 +2
+ Misses 385 384 -1
+ Partials 203 202 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: FINGERPRINT as last attribute
Per RFC 5389, FINGERPRINT must be the last attribute.
This is the reason Coturn interoperability tests (for IPv6 ONLY) are failing when using a Pion TURN client against a Coturn server in pion/turn#555. When requesting IPv6 allocations the REQUESTED-ADDRESS-FAMILY attribute is sent, and its being sent after FINGERPRINT - which is incorrect, per RFC 5389.