Permissively parse SDPs unless completely invalid#3297
Merged
philipch07 merged 1 commit intomasterfrom Dec 11, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (69.56%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3297 +/- ##
==========================================
- Coverage 84.30% 84.26% -0.05%
==========================================
Files 80 80
Lines 9133 9144 +11
==========================================
+ Hits 7700 7705 +5
- Misses 1014 1019 +5
- Partials 419 420 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f821646 to
b6524bd
Compare
JoTurk
approved these changes
Dec 11, 2025
Member
JoTurk
left a comment
There was a problem hiding this comment.
Pretty cool change, and I like the early return.
b6524bd to
71e1084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of throwing errors since there are numerous SDP types, we can be more permissive by allowing them to be ignored (with a logged warning) and instead bubble up the last error if they all failed.
This is a re-implementation of pion/sdp#233, but in a more appropriate place (see pion/sdp#233 (comment)).
Reference issue
Resolves #1315.