Advertise ICE renomination option in SDP#3317
Merged
Conversation
JoTurk
requested review from
Sean-Der,
kevmo314,
nils-ohlmeier and
philipch07
JoTurk
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3317 +/- ##
==========================================
+ Coverage 84.95% 85.04% +0.09%
==========================================
Files 80 80
Lines 9478 9482 +4
==========================================
+ Hits 8052 8064 +12
+ Misses 1004 997 -7
+ Partials 422 421 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
force-pushed
the
ice-renomination-option
branch
from
55e3b07 to
c780e7d
Compare
JoTurk
force-pushed
the
ice-renomination-option
branch
from
c780e7d to
d8828d6
Compare
kevmo314
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Advertise renomination ice-option when it's enabled. https://datatracker.ietf.org/doc/html/draft-thatcher-ice-renomination-01#section-3
continues pion/sdp#237 and #3306