Skip to content

Replace orientation values by strings, as supported by gcloud #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace orientation values by strings, as supported by gcloud #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ firebaseTestLab {
// you can list all available via `gcloud firebase test android models list` for your device model
androidApiLevels = [23]

// You can test app in landscape and portrait
// screenOrientations = [com.appunite.firebasetestlabplugin.model.ScreenOrientation.PORTRAIT, com.appunite.firebasetestlabplugin.model.ScreenOrientation.LANDSCAPE]
// You can test app in landscape, portrait and default
// More info in: https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run#--orientations
// screenOrientations = ["portrait", "landscape", "default"]

// Choose language (default is `en`)
// you can list all available via `gcloud firebase test android locales list`
Expand Down
2 changes: 1 addition & 1 deletion ...n/src/main/java/com/appunite/firebasetestlabplugin/cloud/FirebaseTestLabProcessCreator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ object FirebaseTestLabProcessCreator {
"--app=${processData.apk}",
"--locales=${device.locales.joinArgs()}",
"--os-version-ids=${device.androidApiLevels.joinArgs()}",
"--orientations=${device.screenOrientations.map { orientation -> orientation.gcloudName }.joinArgs()}")
"--orientations=${device.screenOrientations.joinArgs()}")
.plus(when (processData.testType) {
TestType.Robo -> sequenceOf("--type=robo")
is TestType.Instrumentation -> sequenceOf("--type=instrumentation", "--test=${processData.testType.testApk}")
Expand Down
2 changes: 1 addition & 1 deletion plugin/src/main/java/com/appunite/firebasetestlabplugin/model/Device.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import java.io.Serializable

class Device(val name: String) : Serializable {
var locales: List<String> = listOf("en")
var screenOrientations: List<ScreenOrientation> = listOf(ScreenOrientation.PORTRAIT)
var screenOrientations: List<String> = listOf("portrait")
var androidApiLevels: List<Int> = listOf()
var deviceIds: List<String> = listOf()
var timeout: Long = 0
Expand Down
12 changes: 0 additions & 12 deletions plugin/src/main/java/com/appunite/firebasetestlabplugin/model/ScreenOrientation.kt
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions sample/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ firebaseTestLab {
// you can list all available via `gcloud firebase test android models list` for your device model
androidApiLevels = [23]

// You can test app in landscape and portrait
// screenOrientations = [com.appunite.firebasetestlabplugin.model.ScreenOrientation.PORTRAIT, com.appunite.firebasetestlabplugin.model.ScreenOrientation.LANDSCAPE]
// You can test app in landscape, portrait and default
// More info in: https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run#--orientations
// screenOrientations = ["portrait", "landscape", "default"]

// Choose language (default is `en`)
// you can list all available via `gcloud firebase test android locales list`
Expand Down