Open
Conversation
This changes the following things - increases required minimum cmake to 3.16 - modernizes cmake to set target scoped configurations - removes Qt4 compatibility in cmake as it not mentioned in the readme anymore - replaces QtKeychain find_packages with a FetchContent directly from github
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the following things
When configuring the project it is necessary now to provide the CMAKE_PREFIX_PATH to the Qt version that should be used. That is the recommended way from Qt as documented at Getting started with cmake: