fix: Use backward-compatible default CLI value#630
Merged
Conversation
Use `capture_default_str()` instead of `default_value()` for backward compatibility.
We never use anything other than `std::cout` and the class should be refactored anyway.
elshize
force-pushed
the
backward-compatible-default
branch
from
f8d082a to
3169246
Compare
gustingonzalez
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
capture_default_str()instead ofdefault_value()for backward compatibility.Using
default_value()failed on one of the tests onmainthat used system dependency for CLI11 that was in a lower version.Also deleting operators that are already implicitly deleted.