Skip to content

Fix query algorithm WAND validation and duplicate TSV header in queries#633

Merged
elshize merged 3 commits intopisa-engine:mainfrom
gustingonzalez:fix/queries
Mar 22, 2026
Merged

Fix query algorithm WAND validation and duplicate TSV header in queries#633
elshize merged 3 commits intopisa-engine:mainfrom
gustingonzalez:fix/queries

Conversation

@gustingonzalez
Copy link
Copy Markdown
Collaborator

Key changes in this pull request:

  1. Fix ranked_and, ranked_or, ranked_or_taat, ranked_or_taat_lazy incorrectly marked as not requiring WAND data in VALID_ALGORITHMS. This did not cause issues because the check was correctly enforced at runtime.
  2. Centralize WAND data validation using VALID_ALGORITHMS instead of duplicating check in queries, reducing the need for double checks when modifying the logic.
  3. Fix duplicate TSV header when running queries using multiple algorithms (previously printed for each algorithm).

@gustingonzalez gustingonzalez requested a review from elshize March 21, 2026 20:41
Copy link
Copy Markdown
Member

@elshize elshize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 I'll merge this. FYI I filed a follow-up #634 to improve VALID_ALGORITHMS mapping, you can have a look if you're interested.

@elshize elshize merged commit b7c121a into pisa-engine:main Mar 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants