Skip to content

Updated plugin and removed onmousemove and ontouchmove events #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
micpob wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated plugin and removed onmousemove and ontouchmove events #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab7562
Removed onmousemove and ontouchmove detection for a better UX.
micpob Nov 26, 2017
73f0aea
Updated event.handle to event.dispatch, removed onmousemove and ontou…
micpob Nov 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions jquery.longclick-min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions jquery.longclick.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@
/* normal technique for standard mouse-based interaction */
$(this)
.bind(_mousedown_, schedule)
.bind([_mousemove_, _mouseup_, _mouseout_, _contextmenu_].join(' '), annul)
.bind([_mouseup_, _mouseout_, _contextmenu_].join(' '), annul)
.bind(_click_, click)
}else{
/* and special handling for touch-based interaction on iPhone-compatibile devices */
touch_enabled(this)
.bind(_touchstart_, schedule)
.bind([_touchend_, _touchmove_, _touchcancel_].join(' '), annul)
.bind([_touchend_, _touchcancel_].join(' '), annul)
.bind(_click_, click)
.css({ WebkitUserSelect: 'none' })
}
Expand All @@ -89,7 +89,7 @@
Commit subset of touch events to trigger jQuery events of same names
*/
function touch_enabled(element){
$.each('touchstart touchmove touchend touchcancel'.split(/ /), function bind(ix, it){
$.each('touchstart touchend touchcancel'.split(/ /), function bind(ix, it){
element.addEventListener(it, function trigger_jquery_event(event){ $(element).trigger(it) }, false);
});
return $(element);
Expand All @@ -114,7 +114,7 @@
/* Flag as "fired" and rejoin the default event flow */
$(element).data(_fired_, true)
event.type= type
jQuery.event.handle.apply(element, args)
jQuery.event.dispatch.apply(element, args)
}
}
function annul(event){
Expand All @@ -135,12 +135,12 @@

/* Event strings */
_mousedown_= 'mousedown'+namespace, _click_= 'click'+namespace,
_mousemove_= 'mousemove'+namespace, _mouseup_= 'mouseup'+namespace,
_mouseup_= 'mouseup'+namespace,
_mouseout_= 'mouseout'+namespace, _contextmenu_= 'contextmenu'+namespace,
_touchstart_= 'touchstart'+namespace, _touchend_= 'touchend'+namespace,
_touchmove_= 'touchmove'+namespace, _touchcancel_= 'touchcancel'+namespace,
_touchcancel_= 'touchcancel'+namespace,

/* Storage keys */
_duration_= 'duration'+namespace, _timer_= 'timer'+namespace, _fired_= 'fired'+namespace

})(jQuery);
})(jQuery);