Open
Conversation
sveredyuk
reviewed
Jun 11, 2017
homework.rb
Outdated
| def generate | ||
| # put your solution here (delete the line below) | ||
| rand(1000000).to_s + '-' + rand(1000000).to_s | ||
| a, b, c = rand(1000...9999), rand(1000...9999), rand(1000...9999) |
There was a problem hiding this comment.
It's not the ruby way to name variables likes that: a, b, c, x, y.
Name of variable should explain content or describe appointment
use something like first_part, etc
There was a problem hiding this comment.
Also you 3 times called rand(1000...9999). What about some DRY (don't repeat yourself) ?
Correcting mistakes. Is it right?
change homework 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Svyryda.homework1.pull request