Draft
Conversation
sveredyuk
reviewed
Sep 23, 2020
Contributor
sveredyuk
left a comment
sveredyuk
left a comment
There was a problem hiding this comment.
Good job but we have something to improve
app/models/euro.rb
Outdated
| @@ -0,0 +1,4 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Euro < Account | |||
Contributor
There was a problem hiding this comment.
IMHO we should allow a user to create own currencies and do not hardcode them
Contributor
Author
There was a problem hiding this comment.
okey, i will check how to realize that
and i am sorry for slow response, notifications broken on my phone(
Contributor
Author
There was a problem hiding this comment.
I am going to use this gem for exchanging money.
What do you thing about it?
Contributor
There was a problem hiding this comment.
Decent solution. Have nothing against it.
| create_table :accounts do |t| | ||
| t.string :name | ||
| t.decimal :balance, default: 0, null: false | ||
| t.string :type, default: :UkrainianHryvnia, null: false |
Contributor
There was a problem hiding this comment.
t.string :currency_code, default: 'UAH', null: false + index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.