Fixed: MPL 2 license detection fails when license contains a copyright header #1069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Mozilla Public License can contain a copyright notice before the license header. For example:
https://github.com/hashicorp/yamux/blob/v0.1.2/LICENSE#L1-L3
My understanding of the license is that this is valid:
To resolve that, this allows
HeaderMatcherto search the first 3 lines of the license to identify it. This matches the approach used by the MPL 1.1 definition:LicenseFinder/lib/license_finder/license/definitions.rb
Line 302 in 00b04cb