Improvements of dashboard extension #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system section is meant for administration of the TYPO3 system, while a dashboard is a typical user module as every dashboard is bound to individual users.
The abstract widget only contains a helper method to convert a flexform string to an array, which really should be done in the widget settings model already. Deprecate the abstract and add a method to the model to return the array directly. This is breaking for widgets, that did not use the "settings" namespace in their flexforms
Since the namespace change removed every single bit of class compatibility anyway, we can safely remove the deprecated class.
While storing some settings as well, this class represents a concrete widget being used on a dashboard. Clarify this by renaming the class and variables
Since it is in the domain of the dashboard to know, which the next available vertical position is available, we put this logic into the dashboard model and on the go fix a bug here.
Widgets are only valid when attached to a dashboard and are not aggregate root objects. Thus the repository is removed and widgets are now only fetched from the current dashboard
Let widgets define a AMD module that will be initialized with each widget that is rendered. The AMD module can be registered when registering the widget with the "jsModule" property. The module must implement bootstrapWidget, which will be called with the widget DOM element and the dashboard app on initial rendering of the widget. We also introduce events when the widget content will be and has been updated.
This makes it now mandatory to be set
…ion service independent.
…ion_service_instead_of_from_forms_extension [BUGFIX] prevent errors when forms extension isn't use, make translation service independent.
[TASK] update composer dependencies
Open
…uirements Use typo3/cms-sys-action as a requirement in the composer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.