Skip to content

fix: add missing dependencies to hooks #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yovach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add missing dependencies to hooks #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/components/Application.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {

Check warning on line 1 in src/components/Application.tsx

View workflow job for this annotation

GitHub Actions / Verify (Lint, test:lint, false) 

Run autofix to sort these imports!
FiberProvider,
useContextBridge,
} from 'its-fine';
Expand Down Expand Up @@ -94,7 +94,7 @@
applicationRef.current = application;
updateResizeTo();
onInit?.(application);
}, [onInit]);
}, [onInit, updateResizeTo]);

useIsomorphicLayoutEffect(() =>
{
Expand Down Expand Up @@ -144,17 +144,12 @@
// @ts-expect-error The value of `children` is fine, but `PixiReactChildNode` doesn't strictly adhere to the `ReactNode` structure.
root.render((<Bridge>{children}</Bridge>), applicationProps);
}
}, [
applicationProps,
children,
handleInit,
resizeTo,
]);
}, [Bridge, applicationProps, children, handleInit, resizeTo]);

useIsomorphicLayoutEffect(() =>
{
updateResizeTo();
}, [resizeTo]);
}, [updateResizeTo]);

useIsomorphicLayoutEffect(() =>
{
Expand Down
Loading