fix: pass DevTools config through createReconciler #632
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @AlaricBaraou! Giving it a try now. |
Collaborator
|
I see in the r3f thread you commented abot the types not being updated yet. |
thejustinwalsh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: #631
We had the same issue in @react-three/fiber
And this PR fix it pmndrs/react-three-fiber#3594
I found out that injectIntoDevTools is not the correct way to pass the DevTools config anymore. It changed in that PR https://github.com/facebook/react/pull/30522/files
I did not test this PR as I'm not familiar with your repo but it should work for you too 👍