CompressedGraphicsModule: fix bad FREE_RANGES end address#317
Merged
charasyn merged 1 commit intopk-hack:masterfrom Feb 18, 2025
Merged
CompressedGraphicsModule: fix bad FREE_RANGES end address#317charasyn merged 1 commit intopk-hack:masterfrom
charasyn merged 1 commit intopk-hack:masterfrom
Conversation
FREE_RANGES are inclusive address ranges, and E1F203 is the address of the spritemap data for the hamburger shop map marker. In rare circumstances, this could cause the very first byte (Y position) of the first portion of the sprite to be overwritten with arbitrary data, if that block of free space was filled all the way to the end. Probably fixes pk-hack#316
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FREE_RANGES are inclusive address ranges, and E1F203 is the address of the spritemap data for the hamburger shop map marker. In rare circumstances, this could cause the very first byte (Y position) of the first portion of the sprite to be overwritten with arbitrary data, if that block of free space was filled all the way to the end.
Probably fixes #316. Hopefully @ichee can confirm that the fix works on their end?