This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[optional] use math to reduce clarity#18
Merged
mxcl merged 2 commits intoupdate-github-actionsfrom Jan 10, 2025
Merged
Conversation
7a07259 to
9311664
Compare
Contributor
Author
|
we should probably migrate to https://github.com/dtolnay/rust-toolchain since the Edit: handled in #19 |
Contributor
|
It’s less clear, but it’s cool if it’s faster. Which I wonder about… you know? Probs should be rebased. |
Contributor
Author
|
the compiler is usually more than capable of figuring out real optimizations. people who care a lot use https://godbolt.org/noscript/rust to check. |
Contributor
Author
|
I'll split up the stuff that's not math games |
e8cfa91 to
153758f
Compare
5086bb8 to
a0ded2c
Compare
beb5a06 to
403cfe5
Compare
403cfe5 to
f13d502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optional reduction in clarity to remove
ifcases and loops.turns on testing, and unit tests the two helper functions.
note that this merges up to #17 , so careful with muddying that diff.updated to split out the github actions work. this now merges to #20