Skip to content

Issue #196 - Swapping out the appendLabel() to prepend/append the edi…#197

Open
zipymonkey wants to merge 2 commits intopkp:developfrom
zipymonkey:196-editortranslator-labels
Open

Issue #196 - Swapping out the appendLabel() to prepend/append the edi…#197
zipymonkey wants to merge 2 commits intopkp:developfrom
zipymonkey:196-editortranslator-labels

Conversation

@zipymonkey
Copy link
Copy Markdown

…tortranslator label.

Before

Screenshot 2025-04-07 at 2 24 19 PM

After

Screenshot 2025-04-07 at 2 24 01 PM

@zipymonkey
Copy link
Copy Markdown
Author

I updated the NameHelper::sameName to compare normalized name instead of just the family name. This was causing individual with the same last name to be combined (e.g. Translator: Ben Johnson and Editor: Andrea Johnson would be displayed as "Ben Johnson").

It does not look like the sameName method is called anywhere else so I think this should be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant