Enhance getProtocol method to handle X-Forwarded-Proto #12132
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prioritize X-Forwarded-Proto header for protocol detection. Implementing what is proposed at pkp#6851
asmecher
reviewed
Dec 19, 2025
Member
asmecher
left a comment
asmecher
left a comment
There was a problem hiding this comment.
I'll add a more general comment on the issue, but here's a detail...
| $this->_protocol = strtolower($_SERVER['HTTP_X_FORWARDED_PROTO']); | ||
| } else { | ||
| $this->_protocol = (!isset($_SERVER['HTTPS']) || strtolower($_SERVER['HTTPS']) != 'on') ? 'http' : 'https'; | ||
| Hook::call('Request::getProtocol', [&$this->_protocol]); |
Member
There was a problem hiding this comment.
This removes the hook's ability to override the returned value in all cases, which might be important. I'd suggest promoting this outside of this conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritize X-Forwarded-Proto header for protocol detection. Implementing what is proposed at #6851