Bugfix stable 3 4 0 100 fix captcha on login#129
Open
jonasraoni wants to merge 4 commits intopkp:stable-3_4_0from
Open
Bugfix stable 3 4 0 100 fix captcha on login#129jonasraoni wants to merge 4 commits intopkp:stable-3_4_0from
jonasraoni wants to merge 4 commits intopkp:stable-3_4_0from
Conversation
Author
|
@kaitlinnewson / @Vitaliy-1, if everything's ok, there are other PRs attached to the issue: |
| <fieldset class="recaptcha_wrapper"> | ||
| <div class="fields"> | ||
| <div class="recaptcha"> | ||
| <div class="g-recaptcha" data-sitekey="{$recaptchaPublicKey|escape}" data-theme="dark"> |
Member
There was a problem hiding this comment.
Was data-theme="dark" intended? I don't see it on the other PRs and I think it would be better without it in this particular theme, since the background is light on the modal as well.
|
|
||
| {* recaptcha spam blocker *} | ||
| {if $recaptchaPublicKey} | ||
| {if $recaptchaPublicKey && \PKP\config\Config::getVar('captcha', 'captcha_on_login')} |
Member
There was a problem hiding this comment.
Perhaps the captcha_on_login and captcha_on_register (below) should also be a variable passed from PragmaThemePlugin.inc.php instead of checking the config in the templates?
Member
|
Hi @jonasraoni, just a couple of minor comments above, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.