Add "node_modules" to .gitignore. Clarify how head() works. Add pop() method.#28
Open
bobbydavid wants to merge 3 commits intopkrumins:masterfrom
Open
Add "node_modules" to .gitignore. Clarify how head() works. Add pop() method.#28bobbydavid wants to merge 3 commits intopkrumins:masterfrom
bobbydavid wants to merge 3 commits intopkrumins:masterfrom
Conversation
The head() method was implemented so that it does NOT remove the top value of the list. This refactor makes that more clear, and adds tests to document that behavior. This commit should not change the behavior of head() at all.
The head() method looks at the top value, but does not remove it from the lazy list. The new method, pop(), will remove the value. lazy.pop(f) == lazy.head(f); lazy.skip(1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this library, but was pretty confused by how
head()works. The tests did not really clarify anything.So, I added tests to document how
head()works and simplified the implementation. Turns out it doesn't affect the list, so I addedpop()(which does).Thanks for a really helpful library!