Fix issue #38 Requiring png only exposes the Png() class#39
Open
scottmcginness wants to merge 1 commit intopkrumins:masterfrom
Open
Fix issue #38 Requiring png only exposes the Png() class#39scottmcginness wants to merge 1 commit intopkrumins:masterfrom
scottmcginness wants to merge 1 commit intopkrumins:masterfrom
Conversation
|
ah, I was about to submit an identical PR. any chance of merging this into |
|
@pkrumins It looks like you don’t have time to maintain this project anymore. That’s fine, but please consider giving contributors commit access so they can merge these patches and release some updates. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
NODE_MODULE()intomodule.cppso all classes get initialized