-
Notifications
You must be signed in to change notification settings - Fork 2
Some revisions #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pkyoyetera
wants to merge
30
commits into
master
Choose a base branch
from
pk/re2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d32bad7
some more build options
pkyoyetera 0af71b5
chrono workspace
pkyoyetera ef205e9
build options, fix DayOfTheWeekParser regex bug
pkyoyetera ce27e09
one more regex bug
pkyoyetera 6d14401
optimize build file, fix some compiler warnings
pkyoyetera 2b2b7f7
might be smarter to use an enum than strings
pkyoyetera 1dd0846
another broke regex in ENTimeLaterParser
pkyoyetera ca38726
clean up
pkyoyetera accce59
small issue with this test
pkyoyetera 5229aaf
create call chain in place of using a container
pkyoyetera fcdaca0
unused result container smh
pkyoyetera 097020d
namespace and a small abstraction between result and it's components
pkyoyetera 62f7a13
namespace
pkyoyetera ab86603
changelog, simple af makefile, bazelrc
pkyoyetera 359158c
workflow
pkyoyetera d39d859
oops
pkyoyetera e2bd55e
space
pkyoyetera 871fb58
perhaps make
pkyoyetera 478647a
issa bazel event
pkyoyetera 85a31be
.
pkyoyetera 74f9e89
tab
pkyoyetera 0fd3b33
c++17
pkyoyetera bbf28cf
one more
pkyoyetera 76ff7bd
set gcc version in workflow
pkyoyetera e904da1
syntax
pkyoyetera e2472ac
get compiler first
pkyoyetera 7778bd6
perhaps in the makefile?
pkyoyetera c813b9f
10 not 8
pkyoyetera 208f622
syntax
pkyoyetera 0262263
not sure why you can't find string_view, wrong gcc version?
pkyoyetera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| test --test_output=all --test_arg=--gtest_color=yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
|
|
||
| on: push | ||
| name: build | ||
| jobs: | ||
| checks: | ||
| name: run | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: | | ||
| sudo apt update | ||
| sudo apt install gcc-10 g++-10 | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| ref: pk/re2 | ||
|
|
||
| - name: run | ||
| uses: ngalaiko/bazel-action/2.0.0@master | ||
| with: | ||
| environment: | ||
| CC: gcc-10 | ||
| CXX: g++-10 | ||
| args: build //... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| * Some abstraction between `parsed_result` and `parsed_components` | ||
| * namespace fixes | ||
| * bug fixes | ||
| * Add easier configuration for debug and optimized build options | ||
| * Added changelog | ||
| * Added simple makefile for github actions | ||
| * set up build github workflow for the repository | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
|
|
||
|
|
||
| export CC := gcc-10 | ||
| export CXX := g++-10 | ||
|
|
||
| debug: | ||
| bazel build -c dbg ... | ||
|
|
||
| release: | ||
| bazel build -c opt :time | ||
|
|
||
| clean: | ||
| bazek clean | ||
|
|
||
| test: | ||
| bazel test ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,30 @@ | ||
| workspace(name = "time") | ||
| workspace(name = "chrono") | ||
|
|
||
| load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") | ||
|
|
||
| # ===================================================================== | ||
| # Boost | ||
| # Boost | ||
| # ===================================================================== | ||
| load("@time//:boost.bzl", "boost") | ||
| load("@chrono//:boost.bzl", "boost") | ||
| boost() | ||
|
|
||
| load("@com_github_nelhage_rules_boost//:boost/boost.bzl", "boost_deps") | ||
| boost_deps() | ||
|
|
||
| # ===================================================================== | ||
| # Googletest | ||
| # Googletest | ||
| # ===================================================================== | ||
| git_repository( | ||
| name = "googletest", | ||
| tag = "release-1.8.1", | ||
| remote = "https://github.com/google/googletest", | ||
| tag = "release-1.8.1", | ||
| ) | ||
|
|
||
| # ===================================================================== | ||
| # Google RE2 | ||
| # ===================================================================== | ||
| git_repository( | ||
| name = "re2", | ||
| remote = "https://github.com/google/re2", | ||
| tag = "2021-06-01", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| def default_settings(): | ||
| native.config_setting( | ||
| name = "C++17", | ||
| values = { | ||
| "define": "C++=17", | ||
| }, | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| native.config_setting( | ||
| name = "C++2a", | ||
| values = { | ||
| "define": "C++=2a", | ||
| }, | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| native.config_setting( | ||
| name = "dbg_mode", | ||
| values = { | ||
| "compilation_mode": "dbg", | ||
| }, | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| native.config_setting( | ||
| name = "opt_mode", | ||
| values = { | ||
| "compilation_mode": "opt", | ||
| }, | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| native.config_setting( | ||
| name = "fastbuild_mode", | ||
| values = { | ||
| "compilation_mode": "fastbuild", | ||
| }, | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| def copts(stdc = "-std=c++17", O = "02"): | ||
| default_settings() | ||
| return select({ | ||
| "//:C++17": ["-std=c++17"], | ||
| "//:C++2a": ["-std=c++2a"], | ||
| "//conditions:default": [stdc], | ||
| }) + select({ | ||
| "//:dbg_mode": ["-Wall", "-Wextra", "-Wpedantic"], | ||
| "//:fastbuild_mode": ["-g1"], | ||
| "//:opt_mode": ["-DNDEBUG", O], | ||
| "//conditions:default": [] | ||
| }) | ||
|
|
||
| def linkopts(): | ||
| return select({ | ||
| "//:dbg_mode": ["-g", "-rdynamic"], | ||
| "//:fastbuild_mode": ["-g1", "-rdynamic"], | ||
| "//:opt_mode": ["-rdynamic"], | ||
| "//conditions:default": [] | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.