Plack::Middleware::ConditionalGET only check if HTTP 200 [Bug Fix] #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 2616 Sec 14.25 states that: > If the request would normally result in anything other than a > 200 (OK) status, ... the response is exactly the same as for > a normal GET. There is no point in checking the headers if the status code is something else.
|
This seems reasonable. I'll check if there's any expectation around how this middleware behaves when the backend do send 30x. |
|
Is this alright to merge? |
|
@miyagawa Any update on merging this? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 2616 Sec 14.25 states that:
There is no point in checking the headers if the status code is
something else.