issue #71 - fixed (show_Dialog)#72
Open
Krisolut wants to merge 1 commit intoplamere:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
After logging in with a Google account and then logging out, the login dialog is skipped on the next login attempt. The user is automatically re-authenticated with the previously used Google account, making it impossible to switch to email/password login.
Steps to Reproduce
Expected Behavior
The Spotify login dialog appears, allowing the user to choose between Google and email/password login.
Actual Behavior
The Spotify login dialog is skipped entirely. The user is silently re-authenticated via their still-active Google session.
Root Cause
The Spotify OAuth authorization URL was built without the show_dialog parameter. When omitted, Spotify skips the login dialog if an active session exists. After logout, only the local tokens were cleared — the Spotify/Google session remained active on accounts.spotify.com.
Changes
auth.js — added showDialog parameter to redirectToSpotifyAuth() and show_dialog to the OAuth URL
auth.js — clearTokens() now sets a force_show_dialog flag in localStorage
views/landing.js — login button reads the flag and passes it to redirectToSpotifyAuth()