Merged
Conversation
|
pr is now allowing maploom to build in rpmbuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
BEX-976
What does this PR do?
Should be a more permanent fix to patching the esprima hash as here: #186
Attempts a permanent fix for the esprima hash problems by bumping our jshint version. Additionally resolves the resulting new errors jshint reports.
Before:
Running
npm ciin MapLoom should fail every once in a while because of an outdated esprima hash. Maybe evennpm installfails at some point.After:
The
package-lock.jsonfile will correctly point to the versions we want due to an updatedjshint. Runningnpm cishould no longer fail.Screenshot
N/A
Related Issue
BEX-976