Skip to content

fix: improve host URL construction for provider connection #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nexus49 merged 1 commit into from
Jan 6, 2026
Merged

fix: improve host URL construction for provider connection #236

nexus49 merged 1 commit into from
Jan 6, 2026

Conversation

@nexus49
Copy link
Contributor

@nexus49 nexus49 commented Jan 6, 2026

Summary

  • Fixed URL construction for provider connections by using url.JoinPath instead of manual string concatenation
  • Properly handles path joining to avoid issues with multiple slashes and malformed URLs
  • Added error handling for path joining operations
  • Simplified logic by extracting host+port construction before path joining

This ensures kubeconfig URLs are correctly formed for both external and internal provider connections.

@nexus49 @SAP
fix: improve host URL construction for provider connection and handle…
ffe96d5 
… path joining errors

Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com>
On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
@github-actions github-actions bot added the fix label Jan 6, 2026
akafazov
akafazov approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@akafazov akafazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nexus49 nexus49 merged commit 22c5211 into main Jan 6, 2026
12 checks passed
@nexus49 nexus49 deleted the fix/url-construction-for-kubeconfigs branch January 6, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akafazov akafazov akafazov approved these changes

@aaronschweig aaronschweig aaronschweig approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nexus49 @akafazov @aaronschweig